This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: assertify mcore
- From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <nathan at codesourcery dot com>
- Date: Fri, 06 May 2005 15:12:13 +0200
- Subject: Re: assertify mcore
- References: <427B638F.9040008@codesourcery.com>
FWIW it looks good to me, only a couple of nits:
--- 1083,1092 ----
rtx out_operands[3];
const char * load_op;
char buf[256];
+ int trick;
! trick = try_constant_tricks (INTVAL (operands[1]), &x, &y);
! gcc_assert (trick == 2);
Call these trick_no as later in the patch?
! gcc_unreachable ();
return 0;
Remove the return?
! gcc_unreachable ();
return \"\";
}")
Likewise.
Paolo