Re: warning message control: jumbo patch so far

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

DJ Delorie <dj@redhat.com> writes:

| This patch is the so-far for all my pending warning control patches:
| 
| * Lets warning() itself decide if the warning is printed.
| * Amends each warning with the option which controls it.

This is much better and I like it. 
In order not to hold it indefinitely, I would like you apply it but
follow up with a patch

  * that adds a field "show_options" to diagnostic_context, that
    consistently play the role of diagnostic_show_options;
  * that has this

| +  if (opt && ! option_enabled (opt))
| +    return;
| +
                   done by report_diagnostic.  That for example,
    ensures that any diagnostic kind (error, warning, note, ...) has
    it checked properly.

Thanks!

-- Gaby

-- Gaby