This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Assertidfy m68hc11

Nathan Sidwell wrote: 
This patch assertifies m68hc11 target files.  I built an i686 hosted
m68hc11-elf cross compiler and used that to build newlib.  It ices
doing that, BUT it ices before my patch too.  I've filed PR 21281 about
that.

ok?

For what it's worth, I went through the patch and the conversion looks ok. Two nits:

! gcc_assert (reload_completed == 1);

Maybe only "gcc_assert (reload_completed);".

    switch (GET_CODE (addr))
      {
      case REG:
!       gcc_assert (REG_P (addr) && REG_OK_FOR_BASE_STRICT_P (addr));

The assert on REG_P (addr) is actually unnecessary.

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]