This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Use targetm.foo instead of (*targetm.foo)
On Wed, Apr 27, 2005 at 01:15:23PM -0700, Zack Weinberg wrote:
> Kazu Hirata <kazu@cs.umass.edu> writes:
>
> >> I'm not Kazu, but ... Some *very* old pre-standard compilers only
> >> accepted the (*foo) form. There is no difference in standard C,
> >> hence we prefer the form with less line noise.
> >
> > By "the form with less line noise", you mean targetm.foo form? If so,
> > approved?
>
> Yes and yes. (This is part of ISO C conversion, and so is
> preapproved.)
Note that the (*targetm.foo) (....) form is still preferrable if foo
is allowed by standards to be a function-like macro.
So converting say (*targetm.open) (.....) to targetm.open (.....) is a bad idea,
even if it happens to work on current OSes, it might not work in the future.
Jakub