This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fold_stmt returns non-gimple

From: Diego Novillo <dnovillo at redhat dot com>
To: Richard Guenther <rguenth at tat dot physik dot uni-tuebingen dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 27 Apr 2005 11:10:20 -0400
Subject: Re: [PATCH] fold_stmt returns non-gimple
Organization: Red Hat Canada
References: <Pine.LNX.4.44.0504271630130.7457-100000@alwazn.tat.physik.uni-tuebingen.de>

On Wed, Apr 27, 2005 at 04:34:46PM +0200, Richard Guenther wrote:
> 
> fold_stmt (and its helper set_rhs) happily accept non-gimple
> from fold of the form
> 
>  x = ADDR_EXPR (ARRAY_REF (a, NOP_EXPR(unsigned int, i)));
> 
Where is this NOP_EXPR coming from?  Looks like a bug upstream
from fold_stmt.  Is this generated by an optimizer?

Aren't we failing a verification test with this?  We should be.

> 	* tree-ssa-propagate.c (set_rhs): Check operand of
> 	ADDR_EXPR for gimpliness, too.
> 
Regardless of the upstream problem, this is OK.

Hmm, do we really want to make GIMPLE and adjective too?


Diego.

Follow-Ups:
- Re: [PATCH] fold_stmt returns non-gimple
  - From: Richard Guenther

References:
- [PATCH] fold_stmt returns non-gimple
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]