This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix out of bound access on hard_regno_nregs


Martin Koegler wrote:
-      if (val.start < 0)
+      if (val.start < 0 || val.start >= FIRST_PSEUDO_REGISTER)

This patch is OK.


It needs a ChangeLog entry. The ChangeLog entry should mention the PR number.

It needs the usual testing, e.g. a make bootstrap and make check to check for regressions. I didn't see any explicit mention that you have done this testing, or on what platform it was tested.

I don't see your name in the copyright assignment list at the FSF. We can only accept a few trivial patches without a copyright assignment. If you will be submitting more patches, you should start the paperwork before we start refusing patches. You can see
http://gcc.gnu.org/ml/gcc/2003-06/msg02298.html
for a form to get started.


It is easy enough for me to write the ChangeLog entry for you, and check in the patch for you, but testing will take some time if I have to do it.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]