This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [4.0 PATCH]: backport "unlocked" stdio patches

 > Patch 6 is OK for mainline and the entire set is OK for 4.0.
 > 
 > However, please fix the formatting in Patch 6. Instead of:
 > 
 > unlock_stream (stdin); unlock_stream (stdout); unlock_stream (stderr);
 > 
 > put those calls on separate lines, or, even better, create an
 > unlock_std_streams() function. That change is preapproved.

I installed everything with the formatting fix.  I'll install
unlock_std_streams() as a followup patch after testing.

Thanks for the review!

		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]