This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix NameFinder.java when addr2line does not exist
- From: Bryce McKinlay <mckinlay at redhat dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches Patches <gcc-patches at gcc dot gnu dot org>, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Fri, 22 Apr 2005 13:41:39 -0400
- Subject: Re: [PATCH] Fix NameFinder.java when addr2line does not exist
- References: <747ff3aa3cdcfcedab3aceefceef1bc1@physics.uc.edu>
Andrew Pinski wrote:
The problem here is that we really don't take into effect that a
couple of variables
could be null so get some NPE (NullPointerExceptions). This patch
fixes up the
problem and now on darwin, I can get a backtrace without the message
saying NPE
was thrown when printing out the backtrace.
OK? Bootstrapped and tested on ppc-darwin with no regressions.
Thanks,
Andrew Pinski
ChangeLog:
* gnu/gcj/runtime/NameFinder.java (close): IN, OUT, and PROC can
all be null,
check for that case and don't deference it.
OK
Bryce