This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Assertify rs6000
David Edelsohn wrote:
This generally looks okay, but I found some changes that look like
typos.
The free-standing block in num_insns_constant does not look correct.
! case CONST_DOUBLE:
! if (mode == SFmode)
! {
//first bit & return
! }
{
//second bit
I know that bit's correct -- I checked it several times. The original
code looked like,
if (code == CONST_INT)
something
else if (code == CONST_DOUBLE && mode == SFmode)
first bit & return
else if (code == CONST_DOUBLE)
second bit
else
abort
Admittedly the freestanding block for 'second bit' _looks_ odd. To
remove that I'd have to move the variables declared within it up to an
outer scope. I can do that if you want.
The indentation in rs6000_emit_set_const looks wrong. Is one a
tab and the other spaces?
good catch! A formatting snafu.
Can you try a bootstrap on PPC64 Linux as well?
yes, I do appear to have access to that platform.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk