Re: Ping patch

[Richard Henderson <rth at redhat dot com>]

On Tue, Apr 19, 2005 at 04:13:29PM -0400, Daniel Berlin wrote:
> Alignment analysis for tree optimizations (particularly,
> autovectorization)
> 
> http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02309.html

+  ssa_propagate (visit_stmt, visit_phi_node);
+
+
+  /* Set the alignments */
...
+    }
+/* Free allocated memory.  */
+  finalize ();
...
+}
+/* Compute the meet operator between VAL1 and VAL2:

Watch your whitespace.  There are further mistakes.

+        val.alignment.n = 1;

BITS_PER_UNIT.

+	  val.alignment.offset += (BITS_PER_UNIT * newoffset) % val.alignment.n;

val.alignment.offset = ((val.alignment.offset + BITS_PER_UNIT * newoffset)
			% val.alignment.n);

+  if (TREE_CODE (sym) == PARM_DECL 
+      || (decl_function_context (sym) != current_function_decl
+	  || TREE_STATIC (sym)))

I think this is confused.  All DECLs have their own alignment,
regardless of PARM_DECL or global or whatever.  Further, I think
you're confusing the alignment of &x with the alignment of x.
Certainly you're talking about both things here in the same if.



r~