This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: .opt files for x86, darwin and lynxos


Mike Stump <mrs@apple.com> writes:
> On Apr 20, 2005, at 2:00 PM, Richard Sandiford wrote:
>> --- config/rs6000/rs6000.c    19 Apr 2005 07:07:11 -0000    1.809
>> +++ config/rs6000/rs6000.c    20 Apr 2005 20:30:17 -0000
>> @@ -1313,7 +1313,7 @@ rs6000_override_options (const char *def
>>        rs6000_darwin64_abi = 1;
>>        /* Setting to empty string is same as "-mone-byte-bool".  */
>
> This comment can go.

Good catch, thanks.

>>  #if TARGET_MACHO
>> -      darwin_one_byte_bool = "";
>> +      darwin_one_byte_bool = 1;
>>  #endif
>
> A general comment is this vaporizes lots of comments.  I'm not sure  how
> I feel about that, but thought I would point that out.

The comments above the TARGET_* macros?  I think their documentation
rightfully belongs in invoke.texi, but I suspect you knew I was going
to say that ;)

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]