This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] testsuite: Add new effective target keywords
Am Montag, 18. April 2005 17:23 schrieb Joseph S. Myers:
> On Mon, 18 Apr 2005, [utf-8] BjÃrn Haase wrote:
> > While I think that such kind of information logically should belong to
> > the target board description, I agree that it would be better if one had
> > a solution that is independent of dejagnu.
> > I'd like to suggest to use a method similar to the case of profiling.
> > There, e.g. already is such a hard-coded list of targets in
> > "target-supports.exp" so one might consider to extend the
> > check_effective_target_support_trampolines procedure my patch is
> > proposing so that it first looks at the board_info variable and in case
> > that it does not find anything there, looks at a hand-coded selection
> > list. ?
>
> That seems like the right way to me.
>
> > > As for whether int is more than 16 bits, the testsuite harness should
> > > be able to determine that for itself (for each multilib) by testing the
> > > compiler just as it does e.g. to test for availability of -fpic or
> > > iconv or ilp32 or lp64.
> >
> > Of course that would be desireable. It would be even better, if there
> > were a reliable define symbol that could be used for compile switches, so
> > that some tests need not to be skipped but could be adapted.
>
> #if __INT_MAX__ < 2147483647
> or
> #if __INT_MAX__ > 32767
>
> can be used to adapt tests depending on the size of int. There are plenty
> of __INT_MAX__ conditionals in whatever form already in the testsuite.
> You can use any of the macros documented in cpp.texi.
OK,
in case that there is general agreement on this point, I'd again adapt the
patch to target_supports.exp so that there is
1.) a selection list for excluding target triplets that don't support
trampolines
2.) an automized tests for the int-length effective target based on the
__INT_MAX__ symbol.
Joseph, could you send me then the explicit target triplets, that you would
like to have excluded from trampoline tests?
Yours,
BjÃrn