This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: [4.1 Regression]: java compiler generates wrong code on ia64
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Sun, 17 Apr 2005 19:02:29 -0700
- Subject: Re: PATCH: [4.1 Regression]: java compiler generates wrong code on ia64
- References: <20050417191125.GA29627@lucon.org> <4262B72F.6020400@codesourcery.com>
On Sun, Apr 17, 2005 at 12:21:19PM -0700, Mark Mitchell wrote:
> H. J. Lu wrote:
> >Linkonce and weak functions are never local.
>
> > /* Only create aliases for local functions. */
> >- if (DECL_EXTERNAL (method))
>
> If this code is testing for whether a function has internal linkage,
> then the conditional should be "if (!TREE_PUBLIC (method))". Your patch
> is certainly not correct.
>
default_binds_local_p_1 checks both. I am not sure exactly what
make_local_function_alias is trying to do. Is it for performance
or for correctness?
H.J.