Re: [RFC] [C++ ABI] support non-standard integer types in mangle.c

["Markus F.X.J. Oberhumer" <markus at oberhumer dot com>]

Mark Mitchell wrote:
> Markus F.X.J. Oberhumer wrote:
>
> > Mark Mitchell wrote:
> >
> > > Markus F.X.J. Oberhumer wrote:
> > >
> > > > !           if (TYPE_UNSIGNED (type))
> > > > !             {
> > > > !               write_unsigned_number (4 + len);
> > > > !               write_string ("uint");
> > > > !             }
> > > > !           else
> > > > !             {
> > > > !               write_unsigned_number (3 + len);
> > > > !               write_string ("int");
> > > > !             }
> > >
> > >
> > >
> > >
> > > Do this part as:
> > >
> > >   prefix = TYPE_UNSIGNED (type) ? "uint" : "int";
> > >   write_unsigned_number (strlen (prefix) + len);
> > >   write_string (prefix);
> > >
> > > With that change, this patch is OK.
> >
> >
> > As you don't seem to mind an extra strlen() call I've opted for a little
> > more clarity. Newly built ILP64 gcc and tested. Please review and apply.
>
> The patch is OK.  Do you have a copyright assignment on file?

No - do we really need one for such small diffs ?

The patch transforms an assertion into an if and adds six new (trivial) 
statements, three of which were written by you as listed above...

--
Markus Oberhumer, <markus@oberhumer.com>, http://www.oberhumer.com/