This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: bootstrap compare failure in ada/targparm.o on i686-pc-linux-gnu?
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Richard Henderson <rth at redhat dot com>, Dale Johannesen <dalej at apple dot com>, Graham Stott <graham dot stott at btinternet dot com>, dnovillo at redhat dot com, gcc at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: 14 Apr 2005 23:31:06 -0300
- Subject: Re: bootstrap compare failure in ada/targparm.o on i686-pc-linux-gnu?
- Organization: Red Hat Global Engineering Services Compiler Team
- References: <orhdimgp3c.fsf@livre.redhat.lsd.ic.unicamp.br><4c884331bebb7e2ac70d3b613117654f@apple.com><ord5tagnga.fsf@livre.redhat.lsd.ic.unicamp.br><20050405010117.GA28733@redhat.com><ord5t1nm49.fsf@livre.redhat.lsd.ic.unicamp.br><orwtr9f3l7.fsf@livre.redhat.lsd.ic.unicamp.br><20050411210817.GA10318@redhat.com><oroeckfuoc.fsf@livre.redhat.lsd.ic.unicamp.br><ork6n8fr4g.fsf@livre.redhat.lsd.ic.unicamp.br><ork6n54ci0.fsf@livre.redhat.lsd.ic.unicamp.br><20050414164958.GA21162@redhat.com><or7jj543v0.fsf@livre.redhat.lsd.ic.unicamp.br><425F0A27.4030308@codesourcery.com>
On Apr 14, 2005, Mark Mitchell <mark@codesourcery.com> wrote:
> Alexandre Oliva wrote:
>> On Apr 14, 2005, Richard Henderson <rth@redhat.com> wrote:
>>
>>> On Thu, Apr 14, 2005 at 12:13:59PM -0300, Alexandre Oliva wrote:
>>>
>>>> * tree-eh.c (lower_try_finally_copy): Generate new code in
>>>> response to goto_queue entries as if the queue was sorted by
>>>> index, not pointers.
>>>> (lower_try_finally_switch): Likewise.
>>
>>> Ok.
>> Mark, ok for 4.0 as well?
> Richard, what's your level of confidence here? I'd rather not break
> C++ or Java...
If you look closely, you'll see it's just enforcing a known order to
the operations. If you prefer, I can prepare a patch that copies the
goto_queue, sorts that by index, and iterates on that instead of the
sorted-by-stmt goto_queue.
If it helps any, bootstrap and regtest passed on 4.0 branch,
amd64-linux-gnu.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}