This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC PATCH] Don't use ELF weak for entities with vague linkage when COMDAT groups are available

From: Eric Botcazou <ebotcazou at libertysurf dot fr>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org,Julian Brown <julian at codesourcery dot com>,GCJ Patches <java-patches at gcc dot gnu dot org>
Date: Thu, 14 Apr 2005 19:40:50 +0200
Subject: Re: [RFC PATCH] Don't use ELF weak for entities with vague linkage when COMDAT groups are available
References: <4256FCD3.5030004@codesourcery.com> <200504141904.19477.ebotcazou@libertysurf.fr> <425EA40F.2090103@codesourcery.com>

> > /usr/bin/ld: Warning: size of symbol
> > `__gnu_cxx::__common_pool_policy<__gnu_cxx::__pool,
> > true>::_S_destroy_thread_key(void*)' changed from 21 in testsuite_abi.o
> > to 217 in testsuite_character.o
> > /usr/bin/ld: Warning: size of symbol
>
> Would you check to see that these symbols are indeed in COMDAT groups in
> both files?  If so, then the linker is being silly.  

testsuite_abi.o

  211: 0000000000000000    21 FUNC    GLOBAL DEFAULT   29 
_ZN9__gnu_cxx20__common_pool_policyINS_6__poolELb1EE21_S_destroy_thread_keyEPv

COMDAT group section 
`.group' [_ZN9__gnu_cxx20__common_pool_policyINS_6__poolELb1EE21_S_destroy_thread_keyEPv] 
contains 1 sections:
   [Index]    Name
   [   29]   .gnu.linkonce.t._ZN9__gnu_cxx20__common_pool_policyINS_6__poolELb1EE21_S_destroy_thread_keyEPv


testsuite_character.o

   180: 0000000000000000   217 FUNC    GLOBAL DEFAULT   67 
_ZN9__gnu_cxx20__common_pool_policyINS_6__poolELb1EE21_S_destroy_thread_keyEPv

COMDAT group section 
`.group' [_ZN9__gnu_cxx20__common_pool_policyINS_6__poolELb1EE21_S_destroy_thread_keyEPv] 
contains 1 sections:
   [Index]    Name
   [   67]   .gnu.linkonce.t._ZN9__gnu_cxx20__common_pool_policyINS_6__poolELb1EE21_S_destroy_thread_keyEPv


I guess the answer is positive.

-- 
Eric Botcazou

Follow-Ups:
- Re: [RFC PATCH] Don't use ELF weak for entities with vague linkagewhen COMDAT groups are available
  - From: Mark Mitchell
- Re: [RFC PATCH] Don't use ELF weak for entities with vague linkagewhen COMDAT groups are available
  - From: Julian Brown

References:
- [RFC PATCH] Don't use ELF weak for entities with vague linkage whenCOMDAT groups are available
  - From: Julian Brown
- Re: [RFC PATCH] Don't use ELF weak for entities with vague linkage when COMDAT groups are available
  - From: Eric Botcazou
- Re: [RFC PATCH] Don't use ELF weak for entities with vague linkagewhen COMDAT groups are available
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]