This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch [RFC] fix for an -msse2 failure
- From: Roger Sayle <roger at eyesopen dot com>
- To: Fariborz Jahanian <fjahanian at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 Apr 2005 11:55:49 -0600 (MDT)
- Subject: Re: patch [RFC] fix for an -msse2 failure
On Wed, 13 Apr 2005, Fariborz Jahanian wrote:
> --- 1951,1957 ----
> if (trueop0 == trueop1
> && ! side_effects_p (op0)
> && GET_MODE_CLASS (mode) != MODE_CC)
> ! return !VECTOR_MODE_P (mode) ? const0_rtx : CONST0_RTX (mode);
>
> /* Canonicalize XOR of the most significant bit to PLUS. */
> if ((GET_CODE (op1) == CONST_INT
I think its best/simpler to use CONST0_RTX even for non vector modes,
i.e. just "return CONST0_RTX (mode);". Unfortunately, I need to see
the proposed ChangeLog entry before I can pre-approve this change.
Roger
--