On Tue, Apr 12, 2005 at 04:58:47PM -0700, Mark Mitchell wrote:
Dale Johannesen wrote:
Well, if anybody actually tried this, you found the patch didn't
apply,
because my
tree was a week or so old. I'll go fix that, but I'd like some
feedback
on whether
the general approach seems OK? Thanks.
The overall approach is fine.
I'd prefer that we not play with macros. Instead, #define-ing a
"flag_foo" macro, let's just say "cur_flags->foo". I realize that
will
make the patch much bigger, in a very boring way, but adding to our
macro obfuscation seems even less desirable.
How about sticking with the macros for the initial patch, and
committing to fixing this second? Mixing substantive and
non-substantive changes in one patch makes it much harder to grok.