This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Committed: Complete the .opts conversion for Blackfin

Richard Henderson wrote:
On Tue, Apr 12, 2005 at 04:27:29PM +0200, Bernd Schmidt wrote:

!   if (bfin_lib_id_given && ! TARGET_ID_SHARED_LIBRARY)
!     error ("-mshared-library-id= specified without -mid-shared-library");


I'm pretty sure this fails for id=0.

You're right. I misunderstood what Var() does; I thought it's always a boolean but it isn't with UInteger. I've checked in the patch below to fix it (and this time I tried -mshared-library-id=0 as well...). Thanks.


Bernd 
	* config/bfin/bfin.c (bfin_lib_id_given): New static variable.
	(bfin_handle_options): Set it if -mshared-library-id= is seen.
	* config/bfin/bfin.opt (mshared-library-id=): Lose
	Var(bfin_lib_id_given).
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]