This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] New pragma handling mechanism.

From: Zack Weinberg <zack at codesourcery dot com>
To: Dmitry Kurochkin <dmitry dot kurochkin at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 12 Apr 2005 13:01:27 -0700
Subject: Re: [PATCH] New pragma handling mechanism.
References: <c5742c20504120621218b7b65@mail.gmail.com><87aco398ov.fsf@codesourcery.com><c5742c205041212475f004616@mail.gmail.com>

Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:

>> This is wrong (removing those spaces causes the string to be
>> misformatted in releases) and should not be necessary.
> I've inserted this spaces in version.c directly, so the version string
> is the same.

In a release, DATESTAMP and DEVPHASE are empty, and that $(if ...)
mess makes the spaces go away.  If you put them in version.c, that
doesn't happen, and the final string is wrong.

zw

References:
- [PATCH] New pragma handling mechanism.
  - From: Dmitry Kurochkin
- Re: [PATCH] New pragma handling mechanism.
  - From: Zack Weinberg
- Re: [PATCH] New pragma handling mechanism.
  - From: Dmitry Kurochkin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]