This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] New pragma handling mechanism.
- From: Dmitry Kurochkin <dmitry dot kurochkin at gmail dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 12 Apr 2005 23:47:04 +0400
- Subject: Re: [PATCH] New pragma handling mechanism.
- References: <c5742c20504120621218b7b65@mail.gmail.com> <87aco398ov.fsf@codesourcery.com>
- Reply-to: Dmitry Kurochkin <dmitry dot kurochkin at gmail dot com>
> You're still not doing the c_lex stuff the way I want it done. There
> should be no need for a global function pointer, if you do it right.
> Move the existing c_lex to a C-front-end-specific file and rename it,
> e.g. c_get_token. Create new functions in both the C and C++ front
> ends, named c_lex, that do essentially what your c_pragma_lex does
> now. The only callers of that function should be the pragma handlers.
OK.
> Also, you need to implement the c_pragma_unblock_tokens() function
> that Richard Henderson wanted. This function, if called when the
> current token is the CPP_EOF token that ends a pragma, consumes that
> token so the pragma handler can see subsequent file content. It is an
> error to call it at any other time.
OK.
> This is wrong (removing those spaces causes the string to be
> misformatted in releases) and should not be necessary.
I've inserted this spaces in version.c directly, so the version string
is the same.
> No one else has reported a problem, so I suspect you have a buggy shell and/or
> Make.
I've tried this on zsh/bash/sh. Will try to upgrade make.
--
Dmitry