This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use gcc_assert and gcc_unreachable in the SPARC backend


> > Two nits: I'd prefer the globally negative form for
> >
> > +      gcc_assert (! LEAF_SIBCALL_SLOT_RESERVED_P || ! final_sequence);
>
>  Only this place?  None of the other !foo && !bar?

Yes, only this one popped up.  And I think && is more human-grokable than || 
in a negation.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]