Re: [PATCH] Fix fortran/13257, Error instead of warning for missing comma in format string

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Apr 8, 2005, at 2:20 PM, Tobias Schlüter wrote:

> > @@ -853,8 +854,8 @@ parse_format_list (void)
> >        goto finished;
> >
> >      default:
> > -      error = "Missing comma in format";
> > -      goto finished;
> > +      /* Assume a missing comma, this is a GNU extension */
> > +      goto format_item_1;
> >      }
>
> Please add a call to gfc_notify_std here, and depending on its result 
> give an
> error or continue parsing the format string.  This is in line with our 
> policy
> regarding extensions and should alleviate Richard's concern, even 
> though I
> couldn't create a testcase exposing the ambiguity he referred to.  
> Given the
> subtleties of fixed-form I wouldn't be surprised if it really exists, 
> and we
> should definitely add it to the testsuite if someone can give an 
> example.)

This is inside the library so at this point, we should have warned 
about it
already.  The front-end part already have a call to gfc_notify_std.

Thanks,
Andrew Pinski