Re: [fortran, patch] Enable Hollerith constant and character array in format tag.

[Steven Bosscher <stevenb at suse dot de>]

On Friday 08 April 2005 04:11, Feng Wang wrote:
> Is anybody reviewing this? I think this is also an important extension.

I agree that it is important, but there really is more to do before
the patch is OK.  At least two things come to mind (I hope I can't
think up more for the next review ;-)
1. Can you add more test cases that:
   * make sure we do the warnings;
   * make sure holleriths can only appear where they are
     allowed to appear (which is itself a debatable question);
   * make sure (*cough*) "numerical" holleriths are converted
     to the proper value;
   * see what parts of the good old g77 test suite can now be
     included in the gfortran test suite.
2. Document the extension (perhaps c&p from the g77 manual?).

Re. 1, consider for example:
 
       program freakmeout
       implicit none
       real r, x, y
       parameter (r = 4hdead)
       parameter (y = 4*r)
       x = sin(r)
       x = x * r
       x = x / r
       x = x + r
       x = x - r
       end

This segfaults with your patch.

Gr.
Steven