This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: tree profiling merge: removal of variables whose references was optimized out
- From: Jan Hubicka <jh at suse dot cz>
- To: James E Wilson <wilson at specifixinc dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 7 Apr 2005 09:23:25 +0200
- Subject: Re: tree profiling merge: removal of variables whose references was optimized out
- References: <20050328225809.GX31388@kam.mff.cuni.cz> <4254B7B4.1080503@specifixinc.com>
> Jan Hubicka wrote:
> > * cgraph.c (cgraph_varpool_node_name): New function.
> > (dump_cgraph_varpool_node): New function.
> > (dump_varpool): New function.
> > * cgraphunit.c (cgraph_optimize): Dump varpool.
> >...
>
> This patch was incompletely and/or incorrectly checked in.
>
> The patch removes a hunk of code in final.c, but this code is still in
> mainline. There could be other problems with this patch.
>
> You really need to audit your patch and your checkin, to make sure you
> checked in the correct patch, and that the ChangeLog entry matches what
> you checked in.
>
> I've also noted this problem in PR 20717, in comment #3.
I've just returned from a trip yesterday and I am going to look into
this today. Sorry for the problems (the commit conflicted with other
aliasing changes), however the changes in final.c should not cause any
important damage - I believe that the IA-64 problem really is the missed
FDESC_EXPR analysis. Unforutnately my IA-64 bootstrap dies earlier on
abort in cfglayout.c I am looking into now, so I will move to this
problem once this is fixed.
Honza
> --
> Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com