This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] Fix PR199785, symbol visibility in libgcov
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: Janis Johnson <janis187 at us dot ibm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 6 Apr 2005 15:24:01 -0700
- Subject: Re: [PING] Fix PR199785, symbol visibility in libgcov
- References: <20050321171755.GA4806@us.ibm.com> <423F076F.6090707@codesourcery.com>
On Mon, Mar 21, 2005 at 05:42:07PM +0000, Nathan Sidwell wrote:
> Janis Johnson wrote:
> >Patch ping: hide global symbols in libgcov.a so that an instrumented
> >shared library doesn't use the same function instances as an executable
> >that exports globals to the dynamic symbol table. Fixes PR 19985, a
> >regression from GCC 3.3 reported by multiple real users.
> >
> > http://gcc.gnu.org/ml/gcc-patches/2005-03/msg01484.html
>
> ok. Thanks for the explaination.
>
> nathan
Before checking this in for mainline I discovered a problem with the
original patch and submitted another:
http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02767.html
Reproducing the failure requires a shared library used with dlopen and
dlclose from an executable linked with -E, which is beyond the scope of
the GCC testsuite. The patch has been tested by the PR submitter and
with OpenHPI, which ran into the same problems. The original problem
can be duplicated with ACE+TAO test DLL_Test, which passes with the fix
on mainline, 4.0, and 3.4.
May I check in the new patch for mainline? For 4.0? For 3.4? As
noted above, it's a regression from GCC 3.3.
Janis