This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] Fix PR199785, symbol visibility in libgcov


On Mon, Mar 21, 2005 at 05:42:07PM +0000, Nathan Sidwell wrote:
> Janis Johnson wrote:
> >Patch ping: hide global symbols in libgcov.a so that an instrumented
> >shared library doesn't use the same function instances as an executable
> >that exports globals to the dynamic symbol table.  Fixes PR 19985, a
> >regression from GCC 3.3 reported by multiple real users.
> >
> >  http://gcc.gnu.org/ml/gcc-patches/2005-03/msg01484.html
> 
> ok. Thanks for the explaination.
> 
> nathan

Before checking this in for mainline I discovered a problem with the
original patch and submitted another:

  http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02767.html

Reproducing the failure requires a shared library used with dlopen and
dlclose from an executable linked with -E, which is beyond the scope of
the GCC testsuite.  The patch has been tested by the PR submitter and
with OpenHPI, which ran into the same problems.  The original problem
can be duplicated with ACE+TAO test DLL_Test, which passes with the fix
on mainline, 4.0, and 3.4.

May I check in the new patch for mainline?  For 4.0?  For 3.4?  As
noted above, it's a regression from GCC 3.3.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]