This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed gcov patch
Richard Sandiford wrote:
OK, thanks. It turns out a few more uses of GCOV_TYPE_NODE had been
added in the meantime. Rather than change them all to gcov_type_node (),
I just #defined GCOV_TYPE_NODE to gcov_type_node () in coverage.h.
This means that no changes are now needed to tree-profile.c.
yeah, I thought about that. I'm not a huge fan of hiding function calls
inside constant-like #defines.% If someone wants to go through and
replace that bit, they're more than welcome. (Richard, I'm neither asking
you to do it nor revert the patch though.)
nathan
% and before someone says 'but we've got all these other cases', I don't
find that persuaive :)
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk