This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove unused function replace_symbols_in_block from arm.c
- From: Richard Earnshaw <rearnsha at gcc dot gnu dot org>
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 04 Apr 2005 12:42:25 +0100
- Subject: Re: Remove unused function replace_symbols_in_block from arm.c
- Organization: GNU
- References: <20050402171212.22731.qmail@gossamer.airs.com>
On Sat, 2005-04-02 at 18:12, Ian Lance Taylor wrote:
> The function replace_symbols_in_block is static in arm.c and is never
> called or used by anything. However, gcc does not warn about it being
> unused because it calls itself recursively.
>
> replace_symbols_in_block was present in the initial check in of
> thumb.c by Nick Clifton on 1998-03-25. The function was only called
> by thumb_reorg. thumb.c, including replace_symbols_in_block, was then
> copied into arm.c on the branch merged-arm-thumb-backend-branch by
> Richard Earnshaw on 1999-10-26. At that time thumb_reorg was deleted,
> and there was no remaining call to replace_symbols_in_block. That
> branch was merged into mainline by Richard Earnshaw on 2000-04-08. So
> the function has been unneeded for a long time.
>
> This patch removes it. Tested by rebuilding the ARM compiler. OK for
> mainline?
>
> Ian
>
>
> 2005-04-02 Ian Lance Taylor <ian@airs.com>
>
> * config/arm/arm.c (replace_symbols_in_block): Remove static
> function.
OK. If we haven't needed it in 5+ years, we're unlikely to miss it...
R.