Re: AIX bootstrap failure (was Re: Hot/cold partitioning fixes)

[David Edelsohn <dje at watson dot ibm dot com>]

>>>>> Caroline Tice writes:

Caroline> According to the manual, when TARGET_ASM_SELECT_SECTION is used for
Caroline> function decl's, the RELOC parameter is supposed to be 0 if the
Caroline> function is likely to be executed, and 1 if the function is unlikely
Caroline> to be executed.  Therefore it looks like the call above in
Caroline> function_section is passing the correct values.  But I will
Caroline> change the name of the argument from 'unlikely' to 'reloc', and the type
Caroline> from 'bool' to 'int'.  :-)

Caroline> Since, in terms of functionality, it is correct on the 4.0 release 
Caroline> branch, do
Caroline> you want me to make this change there as well or not?

	What documentation are you reading?  Are you looking at an
Apple-local copy?  Mainline gcc/doc/tm.texi and the online GCC manual
states:

@deftypefn {Target Hook} void TARGET_ASM_SELECT_SECTION (tree @var{exp},
int @var{reloc}, unsigned HOST_WIDE_INT @var{align}) Switches to the
appropriate section for output of @var{exp}.  You can assume that
@var{exp} is either a @code{VAR_DECL} node or a constant of some sort.
@var{reloc} indicates whether the initial value of @var{exp} requires
link-time relocations.  Bit 0 is set when variable contains local
relocations only, while bit 1 is set for global relocations.


Also, none of the implementations of the target hook on mainline were
modified to use the parameter to select likely or unlikely.

David