This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] adjust dwarf ra column to libexc expectations on mips-irix


Richard Henderson wrote:
> > +   /* If we're saving the return address register and the dwarf return
> > +      address column number differs from the hard register number, note
> > +      the dwarf return address save too.  */

> There's absolutely no reason to use a parallel here.  Just change
> the original reg to be DWARF_FRAME_RETURN_COLUMN.

 Fine with me. I started that way and then thought it would be good to
 preserve the r31 tracking.

 What is your take on the DWARF_FRAME_REGNUM related adjustment ?

 The initial suggestion was to redefine as

 #define DWARF_FRAME_REGNUM(REGNO) \
    ((REGNO) <= FP_REG_LAST ? (REGNO) : INVALID_REGNUM)

 This gets into a couple of

     warning: signed and unsigned type in conditional expression

 in dwarf2out.c, that I haven't looked at in detail yet.

 Both Richard Sandiford and I were not quite sure the change was absolutely
 required, so ... is it worth pursuing ?

 Thanks in advance,

 Olivier



 
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]