This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping! (4.1 projects, stage 1.2) Hot/cold partitioningfixes
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Caroline Tice <ctice at apple dot com>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>, Geoff Keating <geoffk at geoffk dot org>, Richard Henderson <rth at redhat dot com>
- Date: Wed, 30 Mar 2005 16:19:42 -0800
- Subject: Re: Patch ping! (4.1 projects, stage 1.2) Hot/cold partitioningfixes
- References: <e73c24f7140876dd92a5ed1d6c8733dd@apple.com><m2zmwkhh00.fsf@greed.local><5c0e321f26901d84492dfe29fa755d7e@apple.com><776b1297c1d3595d7b8c9d3699a40431@geoffk.org><87ll84llvz.fsf@codesourcery.com><fa1759014e29042dbf4adeaba50e1ad3@apple.com>
Caroline Tice <ctice@apple.com> writes:
>> I'm still concerned about the RTL optimizers destroying the
>> information that insert_section_boundary_note uses. Other than
>> that, I'm fine with the revised patch.
>
> Yes, that still might be a problem, but if so it is also a problem
> with the implementation that is currently checked into mainline.
This is true. I am therefore not objecting to the patch.
> At least the patch fixes the worst problems with the
> optimization. So...just to make absolutely sure I'm not
> misunderstanding, does the above message from Zack constitute
> approval to commit the patch?
No, not yet; let's see if Richard has any further concerns first.
zw