This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] adjust dwarf ra column to libexc expectations onmips-irix
Olivier Hainque <hainque@adacore.com> writes:
> Richard Sandiford wrote:
>> > + #undef DWARF_FRAME_RETURN_COLUMN
>> > + #define DWARF_FRAME_RETURN_COLUMN (FP_REG_LAST + 1)
>
>> My main concern is that:
>>
>> DWARF_FRAME_REG (FP_REG_LAST + 1) == FP_REG_LAST + 1
>>
>> which is a lie given the definition above. Wouldn't it be safer/
>> more correct to override DWARF_FRAME_REG with something like:
>>
>> #define DWARF_FRAME_REG(REGNO) \
>> ((REGNO) <= FP_REG_LAST ? (REGNO) : INVALID_REGNUM)
>>
>> at the same time?
>
> Possibly. I agree with you on
>
>> I don't know of anything in particular that would break without this though.
>
> still :)
Yeah. I was hoping rth or someone would pipe up ;)
> Would the patch be OK if it passes with that additional change ?
Yes, both for 4.0 and mainline.
Richard