This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gomp] Parser for OpenMP directives


> First, please use the -p option to (cvs) diff so that its easier to
> see the context of the patch.

Ok.

> Second, as far as I can see, the threadprivate directive should be
> handled exactly like we currently handle pragma weak.  I don't see
> what this pragma has to do with starting a declspec.  Similarly wrt
> c_parser_declaration_or_fndef.

We can't handle it like pragma weak because of macro expansion. If we
register threadprivate in omp namespace (like now actually) the macro
expansion will take place only after threadprivate token, not after
omp. So we'll have to register one big handler for pragma omp in
global namespace.

> > +         case PRAGMA_OMP_CLAUSE_IF:
> > +           c_parser_pragma_omp_clause_if (the_parser);
> > +           break;
> 
> You'll need to diagnose clases that aren't allowed to be repeated.
> Perhaps that's easier to do once you have an actual data structure
> that you can record things in...

Yes, here we need to create a structure...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]