This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c

From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
To: aph at redhat dot com
Cc: gcc-patches at gcc dot gnu dot org, binutils at sourceware dot org, gdb at sourceware dot org
Date: Sat, 26 Mar 2005 15:38:29 +0100 (CET)
Subject: Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
References: <200503261421.j2QEL6ll019253@elgar.sibelius.xs4all.nl> <16965.28989.543273.976317@cuddles.cambridge.redhat.com>

   Date: Sat, 26 Mar 2005 14:27:09 +0000
   From: Andrew Haley <aph@redhat.com>

   Mark Kettenis writes:
    > One really shouldn't include <sys/stat.h> without <sys/types.h> on
    > BSD-derived systems.  On most modern BSD's it is brought in by
    > <unistd.h> but vax-dec-ultrix4.0 doesn't have one, so things break.
    > The attached patch fixes that.
    > 

   You must wrap this in #ifdef HAVE_SYS_TYPES_H

Really?  All the other files in libiberty include this file unconditionally.

Mark

Follow-Ups:
- Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
  - From: DJ Delorie

References:
- [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
  - From: Mark Kettenis
- Re: [PATCH/libiberty] Add missing <sys/types.h> in unlink-if-ordinary.c
  - From: Andrew Haley

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]