This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc/gcc ChangeLog cgraph.c varasm.c
- From: Richard Henderson <rth at redhat dot com>
- To: hubicka at gcc dot gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 19 Mar 2005 18:45:35 -0800
- Subject: Re: gcc/gcc ChangeLog cgraph.c varasm.c
- References: <20050318145716.10544.qmail@sourceware.org>
On Fri, Mar 18, 2005 at 02:57:16PM -0000, hubicka@gcc.gnu.org wrote:
> PR middle-end/20225
> * cgraph.c (cgraph_mark_reachable_node): Assert that it is not called
> too late.
> * varasm.c (find_decl_and_mark_needed): Mark needed only when not
> called too late.
Who approved this? I can hardly believe it's correct.
Surely find_decl_and_mark_needed should be unchanged, and
cgraph_mark_reachable_node should verify that the node is
in fact already needed. And if it isn't, then the bug is
elsewhere in that we didn't issue the alias early enough.
r~