This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: BAD PATCH to contrib/gcc_update; try this for portability
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Loren James Rittle <rittle at latour dot waar dot labs dot mot dot com>
- Cc: schwab at suse dot de, gcc-patches at gcc dot gnu dot org
- Date: 18 Mar 2005 21:14:38 -0300
- Subject: Re: BAD PATCH to contrib/gcc_update; try this for portability
- Organization: Red Hat Global Engineering Services Compiler Team
- References: <200503182238.j2IMcBAv055489@latour.waar.labs.mot.com>
On Mar 18, 2005, Loren James Rittle <rittle@latour.waar.labs.mot.com> wrote:
> Good catch. However, that doesn't resolve the issue (unstated in
> my first e-mail) that Zack has a portability issue with his
> first attempt at adding --quiet.
I'm checking this in to fix the problem. We use shell functions, and
I'm pretty sure any shell that supports functions also supports
unset.
Index: contrib/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* gcc_update (silent): Unset instead of initializing to null.
Index: contrib/gcc_update
===================================================================
RCS file: /cvs/gcc/gcc/contrib/gcc_update,v
retrieving revision 1.81
diff -u -p -r1.81 gcc_update
--- contrib/gcc_update 18 Mar 2005 22:43:26 -0000 1.81
+++ contrib/gcc_update 19 Mar 2005 00:12:05 -0000
@@ -56,7 +56,7 @@ self=$0
# This function prints its arguments to standard output unless
# "silent" is set.
-silent=
+unset silent
chat () {
if [ -z "$silent" ]; then
echo "$@"
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}