This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: BAD PATCH to contrib/gcc_update; try this for portability
- From: Loren James Rittle <rittle at latour dot waar dot labs dot mot dot com>
- To: rittle at latour dot waar dot labs dot mot dot com, schwab at suse dot de
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 18 Mar 2005 16:38:11 -0600 (CST)
- Subject: Re: BAD PATCH to contrib/gcc_update; try this for portability
Good catch. However, that doesn't resolve the issue (unstated in
my first e-mail) that Zack has a portability issue with his
first attempt at adding --quiet.
>From the FreeBSD 5 sh(1):
${parameter:+word}
Use Alternate Value. If parameter is unset or null, null is sub-
stituted; otherwise, the expansion of word is substituted.
In the parameter expansions shown previously, use of the colon in the
format results in a test for a parameter that is unset or null; omission
of the colon results in a test for a parameter that is only unset.
Note the final clause (the quiet var is set but null in this case;
thus causing -Q to be added in all cases for FreeBSD 5's sh).
Regards,
Loren