This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Committed] signbitl RTL expansion for Darwin's long double
- From: Richard Henderson <rth at redhat dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 15 Mar 2005 05:08:37 -0800
- Subject: Re: [Committed] signbitl RTL expansion for Darwin's long double
- References: <Pine.LNX.4.44.0503142101320.29447-100000@www.eyesopen.com>
On Mon, Mar 14, 2005 at 09:24:18PM -0700, Roger Sayle wrote:
> *************** const struct real_format c4x_single_form
> *** 4398,4403 ****
> --- 4415,4421 ----
> -126,
> 128,
> -1,
> + -1,
> false,
> false,
> false,
> *************** const struct real_format c4x_extended_fo
> *** 4416,4421 ****
> --- 4434,4440 ----
> -126,
> 128,
> -1,
> + -1,
> false,
> false,
> false,
Here the numbers are 23 and 31 respectively.
> *************** expand_copysign (rtx op0, rtx op1, rtx t
> *** 2866,2872 ****
> if (fmt == NULL || !fmt->has_signed_zero)
> return NULL_RTX;
>
> ! bitpos = fmt->signbit;
> if (bitpos < 0)
> return NULL_RTX;
>
> --- 2866,2872 ----
> if (fmt == NULL || !fmt->has_signed_zero)
> return NULL_RTX;
>
> ! bitpos = fmt->signbit_rw;
> if (bitpos < 0)
> return NULL_RTX;
Here we should move this check. We should use the ro version when
expanding via expand_copysign_absneg and the rw version when using
expand_copysign_bit. This would then allow copysigntf3 to be deleted
from the rs6000 port, and expand_copysign_absneg made static.
r~