This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: UCNs-in-IDs patch
Mark Mitchell <mark@codesourcery.com> writes:
> I guess if all the relevant maintainers are happy this is OK, but
> we've generally avoided #ifdef'd code like this. That is what
> branches are for. (I'm not terribly happy about the mapped location
> #ifdefs, for the same reason.) I'd say that if it's just a little work
> to get the patch into acceptable shape, so that using #ifdef is a
> short-term solution (order of a week), then that's one thing, but if
> it's going to take a month or two, we should get it onto a branch.
Having re-reviewed the original patch, and also having seen the next
patch in the series which is also highly invasive, I am no longer of
the opinion that #ifdefs are a good idea. Branch, or patch all at
once.
zw