This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] MIN/MAX_EXPR transform in phiopts

From: Diego Novillo <dnovillo at redhat dot com>
To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
Cc: gcc-patches at gcc dot gnu dot org, stevenb at suse dot de
Date: Sun, 13 Mar 2005 15:04:38 -0500
Subject: Re: [patch] MIN/MAX_EXPR transform in phiopts
Organization: Red Hat Canada
References: <20050311085213.GA7476@atrey.karlin.mff.cuni.cz> <42330981.2090706@redhat.com> <20050313191725.GA24160@atrey.karlin.mff.cuni.cz>

On Sun, Mar 13, 2005 at 08:17:25PM +0100, Zdenek Dvorak wrote:

> given that blocks_in_phiopt_order does not call dfs_enumerate_from and
> clears the BB_VISITED flag, this usage is OK.  I may change it to using
> sbitmap.
>
Please do.  I've been burnt once or twice by BB_VISITED already.

It's very easy to mess it up.  It'd be nice to get rid of it
completely, but I understand why dfs_enumerate_from needs to use
it.

Perhaps we should remove it completely, rename the bitfield to
'reserved' and have dfs_enumerate_from use it directly.

Diego.

References:
- [patch] MIN/MAX_EXPR transform in phiopts
  - From: Zdenek Dvorak
- Re: [patch] MIN/MAX_EXPR transform in phiopts
  - From: Diego Novillo
- Re: [patch] MIN/MAX_EXPR transform in phiopts
  - From: Zdenek Dvorak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]