This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: PR java/20312 - Checks throws clause even for non-source base classes
- From: Andrew Haley <aph at redhat dot com>
- To: Ranjit Mathew <rmathew at gmail dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 10 Mar 2005 13:44:44 +0000
- Subject: Re: Patch: PR java/20312 - Checks throws clause even for non-source base classes
- References: <39399b9d05031005241a3e9d7c@mail.gmail.com>
Ranjit Mathew writes:
> Hi,
>
> This is a rather silly fix for PR java/20312, but it does work
> and produces no regressions on i686-pc-linux-gnu and an
> XPASS (9.2-implicit-15) in Jacks.
>
> In check_throws_clauses(), we were just ignoring base
> classes who are not being compiled in from Java
> sources - I don't see why, as I could see the throws_list
> just fine and removing this also fixes the bug in question. :-/
Bizarre. We'll have to see if removing this check causes regressions
further down the road.
Incidentally, the current testsuite doesn't use indirect dispatch
because indirect dispatch doesn't work from source and no-one has yet
been able to figure out how to get some tests to run only from
bytecode.
> The second hunk in the patch removes an unused variable
> that was left after my previous patch to nuke xref code.
> I can see this warning during a GCC bootstrap but it does
> not seem to stop the bootstrap. Odd.
>
> I've also attached a patch for the testsuite, including
> removing the xfail for 9.2-implicit-15 in Jacks.
>
> OK for mainline?
OK, thanks.
Andrew.