This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [toplevel] Use a full path to INSTALL
- From: Daniel Jacobowitz <drow at false dot org>
- To: gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
- Date: Tue, 8 Mar 2005 10:57:27 -0500
- Subject: Re: [toplevel] Use a full path to INSTALL
- References: <20041023191658.GA21958@nevyn.them.org>
On Sat, Oct 23, 2004 at 03:16:58PM -0400, Daniel Jacobowitz wrote:
> Bug admin/179 in the binutils bugzilla (on sources.redhat.com) describes a
> problem where "make install" fails when configured with a relative path. On
> systems where /usr/bin/install isn't usable, autoconf carefully does not
> cache the value of INSTALL so that subdirectories will not use it. However,
> we explicitly pass it to subdirectories - we have to, because of
> MAKEOVERRIDES=, or else make install INSTALL="whatever" will not work.
>
> This patch explicitly uses a relative path to install-sh in this case. It
> was the least intrusive solution I could come up with. Tested on
> i386-pc-linux-gnu, with /usr/bin/install moved out of the way. OK?
> 2004-10-23 Daniel Jacobowitz <dan@debian.org>
>
> * configure.in: Use an absolute path to install-sh.
> * configure: Regenerated.
Mark, may I apply this patch to 3.4? This is PR bootstrap/13993.
>
> Index: configure.in
> ===================================================================
> RCS file: /big/fsf/rsync/src-cvs/src/configure.in,v
> retrieving revision 1.242
> diff -u -p -r1.242 configure.in
> --- configure.in 12 Oct 2004 23:40:03 -0000 1.242
> +++ configure.in 23 Oct 2004 19:05:48 -0000
> @@ -80,10 +80,17 @@ AC_SUBST(TOPLEVEL_CONFIGURE_ARGUMENTS)
>
> moveifchange=${srcdir}/move-if-change
>
> +srcpwd=`cd ${srcdir} ; ${PWDCMD-pwd}`
> +
> +# We pase INSTALL explicitly to sub-makes. Make sure that it is not
> +# a relative path.
> +if test "$INSTALL" = "${srcdir}/install-sh -c"; then
> + INSTALL="${srcpwd}/install-sh -c"
> +fi
> +
> # Set srcdir to "." if that's what it is.
> # This is important for multilib support.
> pwd=`${PWDCMD-pwd}`
> -srcpwd=`cd ${srcdir} ; ${PWDCMD-pwd}`
> if test "${pwd}" = "${srcpwd}" ; then
> srcdir=.
> fi
>
--
Daniel Jacobowitz
CodeSourcery, LLC