This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran] PATCH Fix PR 18537
On Sun, Mar 06, 2005 at 12:22:50PM +0100, Tobias Schl?ter wrote:
> Steve Kargl wrote:
> > Oh crap! The patch is causing what appears to be
> > 100s of regressions because the testsuite is
> > just littered with tab characters in the code and
> > dejagnu does a "gfortran -pedantic" run that
> > catchs every single tab.
> >
> >
> > What do (a collective) you want to do? Do I have
> > carte blanche to fix the test suite.
>
> I think you should put this warning under an option. Even if tabs are
> non-standard, they're common. As you have seen in the testsuite :-)
>
Well, I've got a patch that does the following:
kargl[307] gfc41 -o z z.f90
kargl[308] gfc41 -o z -Wall z.f90
Warning: tab character in z.f90 at line 8
kargl[309] gfc41 -o z -Wtabs z.f90
Warning: tab character in z.f90 at line 8
kargl[310] gfc41 -o z -std=f95 z.f90
Warning: tab character in z.f90 at line 8
But, I can't write a dejagnu that does not FAIL.
I've tried the following:
! { dg-do compile }
! { dg-options -Wtabs }
! Check for embedded tabs, which are illegal characters.
program tab
integer i
i = 1
! if (i .eq. 1)TABi = i + 1
if (i .eq. 1) i = i + 1 ! { dg-warning "tab character" "" }
end program tab
gfortran.log shows
Executing on host: /home/kargl/gcc/obj41/gcc/testsuite/../gfortran \
-B/home/kargl/gcc/obj41/gcc/testsuite/../ \
/home/kargl/gcc/gcc41/gcc/testsuite/gfortran.dg/PR18537.f90 -O -Wtabs \
-S -o PR18537.s (timeout = 300)
Warning: tab character in PR18537.f90 at line 8
output is:
Warning: tab character in PR18537.f90 at line 8
FAIL: gfortran.dg/PR18537.f90 -O (test for warnings, line 8)
FAIL: gfortran.dg/PR18537.f90 -O (test for excess errors)
Excess errors:
Warning: tab character in PR18537.f90 at line 8
Any help with a dejagnu test program would be appreciated.
--
Steve