This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] [C++ ABI] support non-standard integer types in mangle.c
- From: Mark Mitchell <mark at codesourcery dot com>
- To: "Markus F.X.J. Oberhumer" <markus at oberhumer dot com>
- Cc: Geoffrey Keating <geoffk at geoffk dot org>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 03 Mar 2005 17:13:30 -0800
- Subject: Re: [RFC] [C++ ABI] support non-standard integer types in mangle.c
- Organization: CodeSourcery, LLC
- References: <4226377B.8000500@oberhumer.com> <m2650847ep.fsf@greed.local> <4227A868.6070502@oberhumer.com>
Markus F.X.J. Oberhumer wrote:
Explicit is better than implicit.
Also note that the length ("u12") of the string has to be encoded, so
there still had to be some test (>= 10 && <= 99).
I agree with Geoff; you should be able to sprintf the name with one
statement, and then prepend the length. Look at write_source_name to
see how to do it easily.
Furthermore, using "__cxa" as the prefix here is wrong; the "vendor" in
this case is "gnu". But, for VECTOR_TYPE, we didn't use even that
explicitly, we just did "__vector". I'd suggest here just using
"int<precision>" like "U5int32".
A revised patch along those lines would be OK for 4.1.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304