This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC/RFT] Patch (java): Switch to new verifier
- From: Tom Tromey <tromey at redhat dot com>
- To: Ranjit Mathew <rmathew at gmail dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: 02 Mar 2005 17:40:47 -0700
- Subject: Re: [RFC/RFT] Patch (java): Switch to new verifier
- References: <4222166D.2060207@gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:
Ranjit> The attached patch proposes to switch GCJ to use the new
Ranjit> verifier.
I think this isn't safe, because vfy_is_assignable_from assumes that
we are generating type assertions. With the C++ ABI, this is not the
case.
Also, I suspect that the new verifier generates typemaps that require
special treatment by subsequent code-generation passes. There are
hacks in place for this, but I'm not sure they work when compiling
with the C++ ABI.
Ranjit> FWIW, the new verifier does seem a bit slower than
Ranjit> the old one, but it sure is a *lot* more comprehensive and
Ranjit> correct in a lot of cases.
I never did any performance tuning of it. That would be
useful... feel like running it through a profiler?
It will be notably worse for code containing subroutines, due to the
way it handles jsr/ret. I think that is basically unavoidable.
Tom