This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Trivial inliner cleanups
- From: Richard Guenther <rguenth at tat dot physik dot uni-tuebingen dot de>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 2 Mar 2005 10:00:13 +0100 (CET)
- Subject: Re: [PATCH] Trivial inliner cleanups
On Tue, 1 Mar 2005, Mark Mitchell wrote:
> Richard Guenther wrote:
> > This patch does some trivial cleanups to the inliner and related
> > code, namely exposing a local define to tree-inline.h and using
> > it in more places instead of 10; removing an unused define and
> > marking a local helper function inline (it's uses are such that
> > it will collapse to almost a NOP at most call-sites).
> >
> > Bootstrapped on x86_64-unknown-linux-gnu.
> >
> > Ok for mainline?
>
> No, because ...
>
> > if (size < 0 || size > MOVE_MAX_PIECES * MOVE_RATIO)
> > ! *count += 10;
>
> ... that 10 isn't INSNS_PER_CALL; it's an estimate of how expensive the
> copy will be. It should be INSNS_PER_<something else>.
I thought that was, "for moves greater than MOVE_MAX_PIECES * MOVE_RATIO
we use memcpy", which is a call?
Richard.
--
Richard Guenther <richard dot guenther at uni-tuebingen dot de>
WWW: http://www.tat.physik.uni-tuebingen.de/~rguenth/