This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] strict types in code generators.


Paul Schlie <schlie@comcast.net> writes:

>> Zack Weinberg wrote:
>>> Marcin Dalecki wrote:
>>>      * genmodes.c, machmode.h: Use the proper enum mode_class type
>>>      instead of the "opaque" unsigned char, since this is what the
>>>      objects in question are really used for.
>>
>> Not OK.  This will quadruple the size of the arrays in question.
>
> - Might this be acceptable if the correspondingly generated insn-modes.h
>   was itself defined to be #include'ed in the beginning of this generated
>   file?

Nope.  That doesn't generally change the size of a variable declared
with enumeration type.  (Yes, there is -fshort-enums, but that breaks
ABIs so it can't be used generally.)

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]