This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] strict types in code generators.
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Paul Schlie <schlie at comcast dot net>
- Cc: Marcin Dalecki <martin at dalecki dot de>, Patch List<gcc-patches at gcc dot gnu dot org>
- Date: Tue, 01 Mar 2005 22:36:39 -0800
- Subject: Re: [PATCH] strict types in code generators.
- References: <BE4AC74A.94E2%schlie@comcast.net>
Paul Schlie <schlie@comcast.net> writes:
>> Zack Weinberg wrote:
>>> Marcin Dalecki wrote:
>>> * genmodes.c, machmode.h: Use the proper enum mode_class type
>>> instead of the "opaque" unsigned char, since this is what the
>>> objects in question are really used for.
>>
>> Not OK. This will quadruple the size of the arrays in question.
>
> - Might this be acceptable if the correspondingly generated insn-modes.h
> was itself defined to be #include'ed in the beginning of this generated
> file?
Nope. That doesn't generally change the size of a variable declared
with enumeration type. (Yes, there is -fshort-enums, but that breaks
ABIs so it can't be used generally.)
zw