This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups


Mark Mitchell wrote:
Daniel Jacobowitz wrote:
Why isn't a::f in a COMDAT group, anyway?
>>
I agree that a::f should be in a COMDAT group, and that this is the root problem. The C++ ABI requires a::f to be COMDAT. I expect that if this problem is fixed, and the missing annotation is added to libjava, that Julian's patch will be OK.

Reverting the patch is the right thing for now.

Julian, do you think you can work out why the inline function isn't being placed in a COMDAT group? (It's apparently being marked weak explicitly, rather than going through the more generic machinery.) If it's not obvious with a little looking, please let me know, and I'll fix it. Then you can retest your patch.

Sure, I will take a look at it!


Cheers,

Julian

--
Julian Brown
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]