This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch proposal for PR 19678


Doesn't this patch mean that DOS line breaks ('\n\r') will be interpreted as
two separators?

No, since DOS line breaks are "\r\n". All matching that was done with '\n' is now done with '\n' or '\r', while all "eating" still only looks for '\n'. In current form, it works only because DOS line breaks are "\r\n" and not "\n\r".


	PR libfortran/19678
	* list_read.c: Add support for DOS files

This level of detail is insufficient. See <http://www.gnu.org/prep/standards/html_node/Change-Logs.html> and <http://gcc.gnu.org/codingconventions.html> for a detailed description of what a ChangeLog should look like. Basically, you must list all changed functions, and the changes therein.

What about:


2005-02-24 FranÃois-Xavier Coudert <coudert@clipper.ens.fr>

PR libfortran/19678
* list_read.c: Add support for DOS files, adding '\r' in the list of possible separators (is_separator and CASE_SEPARATORS). Many tests for "c == '\n'" changed to "(c == '\n' || c == '\r')" (in next_char, eat_separator, finish_separator, read_real and namelist_read).



FX



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]