This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ping] Re: c_common_type_for_mode: pass precision, not mode


On Mon, 2005-02-21 at 19:42 -0500, DJ Delorie wrote:
> I'm back from vacation...
> 
> > > > 2004-12-15  DJ Delorie  <dj@redhat.com>
> > > > 
> > > > 	* c-common.c (c_common_type_for_mode): Pass the mode's precision
> > > > 	to make_[un]signed_type, not the mode itself.
> > Presumably this bootstrapped and comparison tested?  If so, then it's
> > fine (the code in mainline right now is clearly incorrect).
> > 
> > Do you have a testcase?  Even if it only triggers on the internal port
> > it would be good to get the test added to the testsuite.
> 
> There were a number of libgcc sources that triggered this.  I wouldn't
> think a separate testcase would be needed, but I can try to write a
> simple one if you want.
In that case, no need for a separate test.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]